change default deployment name to resource_namespace#101
Closed
carlydf wants to merge 1 commit intotemporalio:mainfrom
Closed
change default deployment name to resource_namespace#101carlydf wants to merge 1 commit intotemporalio:mainfrom
resource_namespace#101carlydf wants to merge 1 commit intotemporalio:mainfrom
Conversation
Member
|
can't seem to load the convo with our new best friend, so don't wanna preemptively approve this rn |
Collaborator
Author
|
I changed my mind, I think resource/namespace is fine actually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed and Why
We discussed using a
.in the past, but the server won't be able to support that before the release of the controller. A/feels off if the ordering isresource/namespacebecause a resource is a sub-component of a namespace, and/implies file-system type hierarchy.I had a convo with ChatGPT comparing some options just for fun, and I agree with it that an underscore separator with resource name followed by namespace name feels like the best option.
Checklist
Closes
How was this tested:
Integration and unit tests
Any docs updates needed?