LastModifier-based ownership transfer with docs#131
Merged
Conversation
carlydf
commented
Sep 3, 2025
carlydf
changed the title
carlydf
commented
Sep 3, 2025
carlydf
changed the title
jlegrone
approved these changes
Sep 3, 2025
Co-authored-by: Jacob LeGrone <jlegrone@users.noreply.github.com>
Co-authored-by: Jacob LeGrone <jlegrone@users.noreply.github.com>
shashwatsuri
pushed a commit
to shashwatsuri/temporal-worker-controller
that referenced
this pull request
Apr 28, 2026
<!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed Add temporary version-metadata method for unblocking worker controller after user modification ## Why? To enable ownership transfer until `OwnerIdentity` management is available per temporalio/api#632 ## Checklist <!--- add/delete as needed ---> 1. Closes temporalio#74 2. How was this tested: Unit tested, but still needs more tests (ie. test that controller correctly unsets the value) 3. Any docs updates needed? Yes, see docs/ownership.md --------- Co-authored-by: Jacob LeGrone <jlegrone@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Add temporary version-metadata method for unblocking worker controller after user modification
Why?
To enable ownership transfer until
OwnerIdentitymanagement is available per temporalio/api#632Checklist
Closes Story for ownership transfer (test, runbook, error that directs to CLI command) #74
How was this tested:
Unit tested, but still needs more tests (ie. test that controller correctly unsets the value)
Any docs updates needed?
Yes, see docs/ownership.md