Check versioned and unversioned pollers in certain cases#132
Merged
Conversation
… new version can roll out
carlydf
commented
Sep 3, 2025
carlydf
commented
Sep 3, 2025
carlydf
commented
Sep 3, 2025
carlydf
commented
Sep 3, 2025
carlydf
commented
Sep 3, 2025
jlegrone
reviewed
Sep 3, 2025
jlegrone
approved these changes
Sep 3, 2025
jlegrone
approved these changes
Sep 3, 2025
shashwatsuri
pushed a commit
to shashwatsuri/temporal-worker-controller
that referenced
this pull request
Apr 28, 2026
) <!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed 1. Check unversioned pollers for the target version if the current version is nil and strategy is progressive 2. Check versioned pollers for Drained versions if the controller is not running a k8s Deployment for that version ## Why? 1. So that we can still respect Progressive rollout steps if Current Version is nil and we confirm unversioned pollers for all Target Version task queues 2. So that we can only block rollout of a new version if we have a pathological # of ineligible for delete versions, meaning in most cases, users can rely on the server to delete their old versions. ## Checklist <!--- add/delete as needed ---> 1. Closes <!-- add issue number here --> 3. How was this tested: - Unit test for maxVersionsIneligibleForDeletion - Integration test where Progressive strategy is respected when unversioned pollers exist - Integration test where deployment is at max versions ineligible and controller doesn't roll out new deployment - Integration test where deployment has max versions but they are eligible for deletion so controller does roll out new deployment 4. Any docs updates needed? <!--- update README if applicable or point out where to update docs.temporal.io -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist
Closes
How was this tested: