Conversation
robholland
requested changes
Sep 4, 2025
Collaborator
robholland
left a comment
robholland
left a comment
There was a problem hiding this comment.
There are failing tests.
jlegrone
approved these changes
Sep 4, 2025
Collaborator
Author
fixed! |
robholland
approved these changes
Sep 5, 2025
jlegrone
pushed a commit
that referenced
this pull request
Sep 10, 2025
<!--- Note to EXTERNAL Contributors -->
<!-- Thanks for opening a PR!
If it is a significant code change, please **make sure there is an open
issue** for this.
We work best with you when we have accepted the idea first before you
code. -->
<!--- For ALL Contributors 👇 -->
Stop these two warnings from happening on every reconcile loop
```
metadata.name: this is used in Pod names and hostnames, which can result in surprising behavior; a DNS label is recommended: [must not contain dots] {"controller": "temporalworkerdeployment", "controllerGroup": "temporal.io", "controllerKind": "TemporalWorkerDeployment", "TemporalWorkerDeployment": {"name":"all-at-once-rollout-2-replicas","namespace":"test-integration-20250903200429"}, "namespace": "test-integration-20250903200429", "name": "all-at-once-rollout-2-replicas", "reconcileID": "5cdf5048-693b-4f77-90ca-30d42444748e"}
```
```
{"level":"info","ts":1755712330.9777546,"msg":"unknown field \"spec.template.metadata.creationTimestamp\"","controller":"temporalworkerdeployment","controllerGroup":"temporal.io","controllerKind":"TemporalWorkerDeployment","TemporalWorkerDeployment":{"name":"helloworld","namespace":"staging"},"namespace":"staging","name":"helloworld","reconcileID":"0fe93d52-0049-437a-8e6e-1ebec7732999"}
```
We should not cut a release with known log spam.
I kept the build ids in Temporal as having any characters at all, but
when converted to a Deployment or Pod name, clean them to DNS only.
<!--- add/delete as needed --->
1. Closes #134
2. How was this tested:
Unit tests for the build id change
Checking logs on integration tests for the other changes. I'd like to
make the tests error if there are too many warnings, but the log level
is `info` on these, so I'm not sure how to make that work
3. Any docs updates needed?
<!--- update README if applicable
or point out where to update docs.temporal.io -->
shashwatsuri
pushed a commit
to shashwatsuri/temporal-worker-controller
that referenced
this pull request
Apr 28, 2026
<!--- Note to EXTERNAL Contributors -->
<!-- Thanks for opening a PR!
If it is a significant code change, please **make sure there is an open
issue** for this.
We work best with you when we have accepted the idea first before you
code. -->
<!--- For ALL Contributors 👇 -->
## What was changed
Stop these two warnings from happening on every reconcile loop
```
metadata.name: this is used in Pod names and hostnames, which can result in surprising behavior; a DNS label is recommended: [must not contain dots] {"controller": "temporalworkerdeployment", "controllerGroup": "temporal.io", "controllerKind": "TemporalWorkerDeployment", "TemporalWorkerDeployment": {"name":"all-at-once-rollout-2-replicas","namespace":"test-integration-20250903200429"}, "namespace": "test-integration-20250903200429", "name": "all-at-once-rollout-2-replicas", "reconcileID": "5cdf5048-693b-4f77-90ca-30d42444748e"}
```
```
{"level":"info","ts":1755712330.9777546,"msg":"unknown field \"spec.template.metadata.creationTimestamp\"","controller":"temporalworkerdeployment","controllerGroup":"temporal.io","controllerKind":"TemporalWorkerDeployment","TemporalWorkerDeployment":{"name":"helloworld","namespace":"staging"},"namespace":"staging","name":"helloworld","reconcileID":"0fe93d52-0049-437a-8e6e-1ebec7732999"}
```
## Why?
We should not cut a release with known log spam.
I kept the build ids in Temporal as having any characters at all, but
when converted to a Deployment or Pod name, clean them to DNS only.
## Checklist
<!--- add/delete as needed --->
1. Closes temporalio#134
2. How was this tested:
Unit tests for the build id change
Checking logs on integration tests for the other changes. I'd like to
make the tests error if there are too many warnings, but the log level
is `info` on these, so I'm not sure how to make that work
3. Any docs updates needed?
<!--- update README if applicable
or point out where to update docs.temporal.io -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Stop these two warnings from happening on every reconcile loop
Why?
We should not cut a release with known log spam.
I kept the build ids in Temporal as having any characters at all, but when converted to a Deployment or Pod name, clean them to DNS only.
Checklist
Closes Get rid of
unknown field \"spec.template.metadata.creationTimestamp\"log spam #134How was this tested:
Unit tests for the build id change
Checking logs on integration tests for the other changes. I'd like to make the tests error if there are too many warnings, but the log level is
infoon these, so I'm not sure how to make that workAny docs updates needed?