Adding a CI action to validate helm chart renderings#199
Merged
Conversation
Shivs11
commented
Feb 17, 2026
carlydf
approved these changes
Feb 19, 2026
Collaborator
|
closes #200 |
shashwatsuri
pushed a commit
to shashwatsuri/temporal-worker-controller
that referenced
this pull request
Apr 28, 2026
<!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed - WISOTT - I have added some very basic "helm lint and helm template" validation checks in this PR. One could very well build on this by adding something like "is the image that is being pulled a valid docker image". I decided to keep it small and just get this in, for now, so that we have a pipeline to test things against. ## Why? - to detect failures quite early ## Checklist <!--- add/delete as needed ---> 1. Closes <!-- add issue number here --> temporalio#191 3. How was this tested: <!--- Please describe how you tested your changes/how we can test them --> 4. Any docs updates needed? <!--- update README if applicable or point out where to update docs.temporal.io -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist
Closes
Automate validation of PR's changing the Helm chart. #191
How was this tested: