Skip to content

fix: use CA certificate from mTLS secret for server verification #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlydf merged 1 commit into from
Feb 27, 2026
Merged

fix: use CA certificate from mTLS secret for server verification #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion internal/controller/clientpool/clientpool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,22 @@ func (cp *ClientPool) fetchClientUsingMTLSSecret(secret corev1.Secret, opts NewC
if err != nil {
return nil, err
}
clientOpts.ConnectionOptions.TLS = &tls.Config{
tlsCfg := &tls.Config{
Certificates: []tls.Certificate{cert},
}
// If the secret contains a CA certificate, use it as the trusted root for server
// certificate verification. This enables connecting to Temporal servers whose TLS
// certificates are signed by private or internal CAs (e.g. cert-manager in a test
// cluster). When ca.crt is absent, Go falls back to the system CA bundle, which is
// the correct behaviour for Temporal Cloud and other publicly-signed endpoints.
if caCert, ok := secret.Data["ca.crt"]; ok && len(caCert) > 0 {
rootCAs := x509.NewCertPool()
if !rootCAs.AppendCertsFromPEM(caCert) {
return nil, errors.New("failed to parse CA certificate from secret")
}
tlsCfg.RootCAs = rootCAs
}
clientOpts.ConnectionOptions.TLS = tlsCfg
expiryTime = exp

c, err := sdkclient.Dial(clientOpts)
Expand Down
Loading