Skip to content

Add CI check to verify Helm chart image references are pullable#222

Merged
carlydf merged 2 commits intomainfrom
helm-checks
Mar 9, 2026
Merged

Add CI check to verify Helm chart image references are pullable#222
carlydf merged 2 commits intomainfrom
helm-checks

Conversation

@carlydf
Copy link
Copy Markdown
Collaborator

@carlydf carlydf commented Mar 8, 2026

What was changed

Uses crane to verify all container image references rendered by the Helm chart exist in their registries, catching broken or deprecated registry paths (e.g. gcr.io deprecation) on every PR and weekly.

Why?

We missed an un-pullable image (maintainer changed the image registry) which needed to be fixed by #219 . Don't want that to happen again

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

Uses crane to verify all container image references rendered by the
Helm chart exist in their registries, catching broken or deprecated
registry paths (e.g. gcr.io deprecation) on every PR and weekly.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@carlydf carlydf requested review from a team and jlegrone as code owners March 8, 2026 06:54
Copy link
Copy Markdown
Contributor

@kianjones9 kianjones9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙌

Copy link
Copy Markdown
Member

@Shivs11 Shivs11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm: however, this PR has to get in first before this one can. If it does not, this workflow would fail since we are fetching the image from the old gcr registry right now in our helm chart.

Copy link
Copy Markdown
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@carlydf carlydf merged commit f79003c into main Mar 9, 2026
15 checks passed
@carlydf carlydf deleted the helm-checks branch March 9, 2026 18:48
shashwatsuri pushed a commit to shashwatsuri/temporal-worker-controller that referenced this pull request Apr 28, 2026
…oralio#222)

<!--- Note to EXTERNAL Contributors -->
<!-- Thanks for opening a PR! 
If it is a significant code change, please **make sure there is an open
issue** for this.
We work best with you when we have accepted the idea first before you
code. -->

<!--- For ALL Contributors 👇 -->

## What was changed
Uses crane to verify all container image references rendered by the Helm
chart exist in their registries, catching broken or deprecated registry
paths (e.g. gcr.io deprecation) on every PR and weekly.

## Why?
We missed an un-pullable image (maintainer changed the image registry)
which needed to be fixed by temporalio#219 . Don't want that to happen again

## Checklist
<!--- add/delete as needed --->

1. Closes <!-- add issue number here -->

2. How was this tested:
<!--- Please describe how you tested your changes/how we can test them
-->

3. Any docs updates needed?
<!--- update README if applicable
      or point out where to update docs.temporal.io -->

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants