Skip to content

fix: clean up Temporal server-side versioning data on TWD deletion #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlydf merged 16 commits into from
Apr 27, 2026
Merged

fix: clean up Temporal server-side versioning data on TWD deletion #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2f52229
fix: deleting a TWD leaves stale versioning data on Temporal server, …
anujagrawal380 Mar 24, 2026
c0ebbaf
fix: persist connection until twd deletes for cleanup
anujagrawal380 Mar 25, 2026
ba857b9
fix: add else log for no ramping version
anujagrawal380 Mar 25, 2026
cd83d2c
fix: use single temporal.io/delete-protection finalizer
anujagrawal380 Mar 25, 2026
05fb227
fix: integration tests
anujagrawal380 Mar 26, 2026
04b61a2
fix: add deletion timeout, strict retry, and RBAC markers for connect…
anujagrawal380 Apr 22, 2026
0ab31a3
fix: remove unused mgr parameter and dead env construction from delet…
anujagrawal380 Apr 26, 2026
a1abea1
fix: remove redundant l.Error log and add ramping version test coverage
anujagrawal380 Apr 27, 2026
202c72d
fix: clear ramping version before setting current to unversioned on d…
anujagrawal380 Apr 27, 2026
9e879a7
fix: re-describe after clearing ramping version to get fresh Conflict…
anujagrawal380 Apr 27, 2026
2e4808b
fix: update handleDeletion docstring to reflect actual cleanup sequence
anujagrawal380 Apr 27, 2026
5d1c04c
fix: regenerate rbac.yaml via make manifests
anujagrawal380 Apr 27, 2026
73d5233
fix: handle AllAtOnce race in deletion test and regenerate CRD manifests
anujagrawal380 Apr 27, 2026
f8e49d9
fix: apply gofmt alignment to deletion integration test
anujagrawal380 Apr 27, 2026
53499d0
fix: use controller identity client to revert current version in dele…
anujagrawal380 Apr 27, 2026
0d587d5
fix: switch deletion test to manual rollout strategy to avoid races
anujagrawal380 Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions helm/temporal-worker-controller-crds/templates/temporal.io_temporalworkerdeployments.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3753,6 +3753,10 @@ spec:
type: integer
signerName:
type: string
userAnnotations:
additionalProperties:
type: string
type: object
required:
- keyType
- signerName
Expand Down Expand Up @@ -3947,6 +3951,18 @@ spec:
x-kubernetes-list-map-keys:
- name
x-kubernetes-list-type: map
workloadRef:
properties:
name:
type: string
podGroup:
type: string
podGroupReplicaKey:
type: string
required:
- name
- podGroup
type: object
required:
- containers
type: object
Expand Down
24 changes: 9 additions & 15 deletions helm/temporal-worker-controller/templates/rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,17 +107,8 @@ rules:
- temporal.io
resources:
- temporalconnections
- workerresourcetemplates
verbs:
- get
- list
- watch
- apiGroups:
- temporal.io
resources:
- temporalworkerdeployments
verbs:
- create
- delete
- get
- list
- patch
Expand All @@ -126,28 +117,31 @@ rules:
- apiGroups:
- temporal.io
resources:
- temporalconnections/finalizers
- temporalworkerdeployments/finalizers
verbs:
- update
Comment thread
anujagrawal380 marked this conversation as resolved.
- apiGroups:
- temporal.io
resources:
- temporalworkerdeployments/status
- workerresourcetemplates/status
- temporalworkerdeployments
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- temporal.io
resources:
- workerresourcetemplates
- temporalworkerdeployments/status
- workerresourcetemplates/status
verbs:
- get
- list
- patch
- update
- watch
# GENERATED RULES END
# Rules for managing resources attached via WorkerResourceTemplate.
# Driven entirely by workerResourceTemplate.allowedResources in values.yaml.
Expand Down
Loading
Loading