Revert cert-manager version constraint to ">=v1.0.0" from 0.23.0 wrongly added by CI#252
Merged
Revert cert-manager version constraint to ">=v1.0.0" from 0.23.0 wrongly added by CI#252
Conversation
…controller into fix-chart-constraint
rkannan82
approved these changes
Mar 30, 2026
carlydf
changed the title
3 tasks
Shivs11
added a commit
that referenced
this pull request
Apr 1, 2026
## Summary - Restores cert-manager dependency version constraint to `">=v1.0.0"` (was overwritten to `0.24.0` by the `v1.5.1` release pipeline) - Fixes the root cause: `sed` commands in `release.yml` used `s/version: .*/...` which matched **all** `version:` lines, including indented dependency versions. Now anchored with `^` to only match the top-level chart version - Updates `Chart.lock` to be in sync with the restored `Chart.yaml` ## Context When the `v1.5.1` release was published, `release.yml`'s helm job: 1. Overwrote the cert-manager constraint from `">=v1.0.0"` to `0.24.0` (same bug as #252) 2. `helm package` then failed because cert-manager `0.24.0` doesn't exist in the jetstack repo 3. The controller chart `0.24.0` was **never published**, but the CRDs chart `0.24.0` was ## After merge Trigger `helm.yml` manually with `version_bump: none`, `ref: main` to publish the controller chart `0.24.0` with `appVersion: 1.5.1`. ## Test plan - [ ] CI passes - [ ] After merge, trigger `helm.yml` with `version_bump: none`, `ref: main` - [ ] Verify controller chart `0.24.0` is published to Docker Hub 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
shashwatsuri
pushed a commit
to shashwatsuri/temporal-worker-controller
that referenced
this pull request
Apr 28, 2026
…gly added by CI (temporalio#252) <!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed and why The CI job that bumps the versions in main also wrongly bumped the cert-manager dependency constraint here: temporalio@1805045 causing build and release error ## Checklist <!--- add/delete as needed ---> 1. Closes <!-- add issue number here --> 2. How was this tested: <!--- Please describe how you tested your changes/how we can test them --> 3. Any docs updates needed? <!--- update README if applicable or point out where to update docs.temporal.io -->
shashwatsuri
pushed a commit
to shashwatsuri/temporal-worker-controller
that referenced
this pull request
Apr 28, 2026
…mporalio#255) ## Summary - Restores cert-manager dependency version constraint to `">=v1.0.0"` (was overwritten to `0.24.0` by the `v1.5.1` release pipeline) - Fixes the root cause: `sed` commands in `release.yml` used `s/version: .*/...` which matched **all** `version:` lines, including indented dependency versions. Now anchored with `^` to only match the top-level chart version - Updates `Chart.lock` to be in sync with the restored `Chart.yaml` ## Context When the `v1.5.1` release was published, `release.yml`'s helm job: 1. Overwrote the cert-manager constraint from `">=v1.0.0"` to `0.24.0` (same bug as temporalio#252) 2. `helm package` then failed because cert-manager `0.24.0` doesn't exist in the jetstack repo 3. The controller chart `0.24.0` was **never published**, but the CRDs chart `0.24.0` was ## After merge Trigger `helm.yml` manually with `version_bump: none`, `ref: main` to publish the controller chart `0.24.0` with `appVersion: 1.5.1`. ## Test plan - [ ] CI passes - [ ] After merge, trigger `helm.yml` with `version_bump: none`, `ref: main` - [ ] Verify controller chart `0.24.0` is published to Docker Hub 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed and why
The CI job that bumps the versions in main also wrongly bumped the cert-manager dependency constraint here: 1805045 causing build and release error
Checklist
Closes
How was this tested: