Skip to content

Fix greedy sed in release.yml and restore cert-manager constraint #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shivs11 merged 1 commit into from
Apr 1, 2026
Merged

Fix greedy sed in release.yml and restore cert-manager constraint #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:
id: bump_version
run: |
# Get current version from Chart.yaml
CURRENT_VERSION=$(grep 'version:' helm/temporal-worker-controller/Chart.yaml | awk '{print $2}')
CURRENT_VERSION=$(grep '^version:' helm/temporal-worker-controller/Chart.yaml | awk '{print $2}')
echo "Current version: $CURRENT_VERSION"

# Determine if this is a patch release based on the git tag
Expand All @@ -121,12 +121,14 @@ jobs:
NEW_VERSION="$MAJOR.$MINOR.$PATCH"
echo "New version: $NEW_VERSION"

# Update Chart.yaml with new version and appVersion
sed -i "s/version: .*/version: $NEW_VERSION/" helm/temporal-worker-controller/Chart.yaml
# Update Chart.yaml with new version and appVersion.
# Use ^version: to only match the top-level chart version, not indented
# dependency versions (e.g. cert-manager) which would otherwise be overwritten.
sed -i "s/^version: .*/version: $NEW_VERSION/" helm/temporal-worker-controller/Chart.yaml
sed -i "s/appVersion: .*/appVersion: ${GITHUB_REF_NAME#v}/" helm/temporal-worker-controller/Chart.yaml

# Also bump CRDs chart version
sed -i "s/version: .*/version: $NEW_VERSION/" helm/temporal-worker-controller-crds/Chart.yaml
sed -i "s/^version: .*/version: $NEW_VERSION/" helm/temporal-worker-controller-crds/Chart.yaml

# Set output variable for use in later steps
echo "version=$NEW_VERSION" >> "$GITHUB_OUTPUT"
Expand Down
6 changes: 3 additions & 3 deletions helm/temporal-worker-controller/Chart.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
dependencies:
- name: cert-manager
repository: https://charts.jetstack.io
version: v1.20.0
digest: sha256:2e79d5fcaa7105af9b35257a74b2ae955a6d73cd0cfa33b8c132e210673eb14a
generated: "2026-03-19T19:11:27.515922-07:00"
version: v1.20.1
digest: sha256:34ef5f9babc7487216ac192df771477dce47e7acc6480177473bbdc4fc61e381
generated: "2026-04-01T12:22:50.99819-04:00"
2 changes: 1 addition & 1 deletion helm/temporal-worker-controller/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ version: 0.24.0
appVersion: 1.5.1
dependencies:
- name: cert-manager
version: 0.24.0
version: ">=v1.0.0"
repository: "https://charts.jetstack.io"
condition: certmanager.install
Loading