Add context.Context to callback.Validator interface#10139
Closed
fretz12 wants to merge 1 commit into
Closed
Conversation
Thread context through to callback validation so that deployments can check caller identity when validating callbacks. The base validator does not use the context.
fretz12
force-pushed
the
fredtzeng/cb-validator-ctx
branch
from
42324d3 to
bbf11a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added
context.Contextas the first parameter to thecallback.Validatorinterface and threaded it through all callsites (
WorkflowHandler,activity.FrontendHandler, and their internal validation/preparation methods). The base validator ignores the context. No behavioral change.Why?
Deployments that decorate the validator (via
fx.Decorate) need access to the gRPC context to check caller identity — e.g. to allow internal callers (scheduler) to attachtemporal://internalcallbacks while rejecting them from external users.How did you test it?