Skip to content

Removes eager creation of Outcome from SANO #10153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
S15 merged 4 commits into from
May 4, 2026
Merged

Removes eager creation of Outcome from SANO #10153

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
74352d4
Removes eager creation of Outcome from SANO
S15 May 1, 2026
0fa81c5
Have a test fail if the outcome softassert is hit
S15 May 1, 2026
0d6f3c1
Revert changes to nexus standalone test
S15 May 4, 2026
cc5b088
complete revert of nexus_standalone_test
S15 May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion chasm/lib/nexusoperation/operation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ func newStandaloneOperation(
UserMetadata: frontendReq.GetUserMetadata(),
Identity: frontendReq.GetIdentity(),
})
op.Outcome = chasm.NewDataField(ctx, &nexusoperationpb.OperationOutcome{})
op.Visibility = chasm.NewComponentField(ctx, chasm.NewVisibilityWithData(
ctx,
frontendReq.GetSearchAttributes().GetIndexedFields(),
Expand Down
13 changes: 12 additions & 1 deletion tests/nexus_standalone_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import (
"go.temporal.io/server/common/payload"
"go.temporal.io/server/common/testing/parallelsuite"
"go.temporal.io/server/common/testing/protorequire"
"go.temporal.io/server/common/testing/testlogger"
"go.temporal.io/server/tests/testcore"
"google.golang.org/protobuf/types/known/durationpb"
)
Expand Down Expand Up @@ -485,7 +486,17 @@ func (s *NexusStandaloneTestSuite) TestDescribeStandaloneNexusOperation() {
// can be completed through the public Nexus task APIs.

s.Run("ScheduleToStartTimeout", func(s *NexusStandaloneTestSuite) {
env := s.newTestEnv()
env := s.newTestEnv(testcore.WithDedicatedCluster())

// When a standalone operation fails from scheduled, we'll never
// set the Outcome variant. Add a testlogger fail here to make sure we don't
// trip the softassert when building our outcome response. This will fail if
// Outcome is created eagerly.
tl, ok := env.Logger.(*testlogger.TestLogger)
s.True(ok)
prev := tl.FailOnError(true)
defer tl.FailOnError(prev)

taskQueue := testcore.RandomizedNexusEndpoint(s.T().Name())
endpointName := env.createNexusEndpoint(env.Context(), s.T(), testcore.RandomizedNexusEndpoint(s.T().Name()), taskQueue).GetSpec().GetName()

Expand Down
Loading