Allow custom query in DeleteExecutionsParams#10176
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added a
Queryfield todeleteexecutions.DeleteExecutionsParamsand propagated it throughDeleteExecutionsWorkflowinto bothGetNextPageTokenActivityandDeleteExecutionsActivity.The activities now pass
params.Querythroughsadefs.QueryWithAnyNamespaceDivision(...)when listing workflow executions, so delete-executions can target a filtered subset instead of always scanning the full namespace.Why?
Allow a custom query to specifically select a subset of workflows to delete.
How did you test it?
Ran:
go test -tags test_dep ./service/worker/deletenamespace/...Potential risks
The main risk is callers passing an overly broad or malformed query. Existing visibility listing errors will fail the workflow, and empty query behavior remains equivalent to the previous full-namespace deletion path via
QueryWithAnyNamespaceDivision("").