Consolidate history handler engine fetch validations#10186
Draft
long-nt-tran wants to merge 1 commit intotemporalio:mainfrom
Draft
Consolidate history handler engine fetch validations#10186long-nt-tran wants to merge 1 commit intotemporalio:mainfrom
long-nt-tran wants to merge 1 commit intotemporalio:mainfrom
Conversation
long-nt-tran
force-pushed
the
consolidate-get-shard-ctx
branch
from
dfe8a11 to
f2fc6ac
Compare
long-nt-tran
force-pushed
the
consolidate-get-shard-ctx
branch
from
f2fc6ac to
5bd9767
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Purely refactoring code blocks of different validation to get the shardContext and historyEngine into a single function
getEngineByNamespaceWorkflow()and use it where applicable (i.e., behavior won't change). The function returns interfaces so I don't think any extra significant copying is incurred.There are other call sites where there's extra stuff to be done in between, I didn't change those call sites in this PR because I want to scope it to only changes that would not change any behavior. But potentially can update all call sites if reviewers are ok with it.
Why?
DRY
How did you test it?
Potential risks
N/A, no behavioral change.