Use softassert for "dirty mutable state" log#10191
Open
Conversation
So failed assertions can be searched/grouped via the FailedAssertion tag. The trailing panic is intentionally left in place; this commit only changes the logger.Error call to softassert.Fail. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
chrsmith
approved these changes
May 7, 2026
Contributor
chrsmith
left a comment
chrsmith
left a comment
There was a problem hiding this comment.
So this will keep the same log (slightly reworded) and potentially fail loudly in test environments? Sounds good to me.
... I'll admit I don't know what dirty mutable state means in this context. But it sounds bad :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Make "dirty mutable state" an invariant.
Why?
The situation describes a bug that needs to be flagged; not just a transient error.
NOTE: the
softassert.Failstill emits the same error log, but with afailed assertion:prefix.