Dual-populate HSM routing fields in CHASM callback tokens#10193
Open
Dual-populate HSM routing fields in CHASM callback tokens#10193
Conversation
stephanos
force-pushed
the
stephanos/failed-get-ns
branch
2 times, most recently
from
a83389c to
fd3f14a
Compare
stephanos
changed the title
stephanos
force-pushed
the
stephanos/failed-get-ns
branch
4 times, most recently
from
d8af7db to
f73c50c
Compare
5 tasks
stephanos
commented
May 7, 2026
| require.Equal(t, enumspb.NEXUS_OPERATION_EXECUTION_STATUS_COMPLETED, descResp.GetInfo().GetStatus()) | ||
| }, 30*time.Second, 200*time.Millisecond) | ||
| } | ||
|
|
stephanos
force-pushed
the
stephanos/failed-get-ns
branch
3 times, most recently
from
2749db6 to
78f4a37
Compare
stephanos
force-pushed
the
stephanos/failed-get-ns
branch
from
78f4a37 to
17f8fb0
Compare
stephanos
commented
May 7, 2026
| ComponentRef: serializedRef, | ||
| NamespaceId: namespaceID, | ||
| WorkflowId: businessID, | ||
| RunId: runID, |
Contributor
Author
There was a problem hiding this comment.
RunId is not strictly needed, but still setting it for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Populate (deprecated)
namespaceIdandworkflowIdfields in CHASM completion token as well.Why?
When the Nexus caller is on CHASM but the Nexus handler is a workflow with HSM-based completion callbacks, the system callback router cannot extract a namespace ID and fails with
"NamespaceID is empty".See also #10194 which attempts to patch this on the handler side (likely not sufficient, though).
How did you test it?