Preserve the original workflow start time on RebuildMutableState - #11668
Open
simvlad wants to merge 1 commit into
Open
Preserve the original workflow start time on RebuildMutableState#11668simvlad wants to merge 1 commit into
simvlad wants to merge 1 commit into
Conversation
rodrigozhou
approved these changes
Aug 20, 2026
simvlad
force-pushed
the
fix-rebuild-preserve-start-time
branch
from
August 20, 2026 19:59
9d61c21 to
f0c02b6
Compare
simvlad
force-pushed
the
fix-rebuild-preserve-start-time
branch
from
August 20, 2026 20:09
f0c02b6 to
f124cd2
Compare
Member
I think we need to discuss this. The command is not that useful if stuck execution will be immediately timedout after rebuild. And I think we observed case where after rebuild an execution timedout immediately even with current implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
AdminRebuildMutableState, invoked bytdbg workflow rebuild, no longer replace the mutable state start time with the current time. It reuses the run's recorded start time, falling back toExecutionInfo.StartTime. Only in case if bothExecutionState.StartTimeandExecutionInfo.StartTimeare empty, the current time will be used.Note one behavior change - a workflow rebuilt after its original run timeout would have expired now times out promptly instead of getting a fresh timeout window.
Why?
Moving the start time to now, often results in workflow with the negative duration, since the end time is kept as is. This could be not handled way by downstream systems.
How did you test it?
Potential risks