Replace errors.As with errors.AsType - #11674
Open
stephanos wants to merge 3 commits into
Open
Conversation
Contributor
|
Claude finished @stephanos's task in 4m 49s —— View job Reviewed 77 files, 2 findings. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
stephanos
commented
Aug 20, 2026
| assert.Contains(t, err.Error(), "fault injection error") | ||
| var reErr *serviceerror.ResourceExhausted | ||
| if errors.As(err, &reErr) { | ||
| assert.ErrorAs(t, err, &reErr) |
Contributor
Author
There was a problem hiding this comment.
Manual change here
stephanos
force-pushed
the
stephanos/go127-errorsastype
branch
from
August 20, 2026 14:31
f66586a to
fdbf8c6
Compare
stephanos
force-pushed
the
stephanos/go127-errorsastype
branch
from
August 20, 2026 16:47
fdbf8c6 to
d94e33a
Compare
stephanos
requested review from
moody-temporal
and removed request for
Shivs11
August 20, 2026 16:47
stephanos
force-pushed
the
stephanos/go127-errorsastype
branch
from
August 20, 2026 17:14
d94e33a to
cff209d
Compare
stephanos
force-pushed
the
stephanos/go127-errorsastype
branch
from
August 20, 2026 17:18
cff209d to
e010d5c
Compare
stephanos
force-pushed
the
stephanos/go127-slicesbackward
branch
2 times, most recently
from
August 21, 2026 03:12
4edeebb to
a3c5707
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
stephanos
force-pushed
the
stephanos/go127-errorsastype
branch
from
August 21, 2026 03:20
e010d5c to
0f203b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.27 prerequisite that applies the
errorsastypeGo fixer and its required error-interface updates.