Add isCloseEventOnly filter in history service#7313
Closed
prathyushpv wants to merge 1 commit intomainfrom
Closed
Conversation
|
This PR was marked as stale. Please update or close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add logic in history service return the last event when HISTORY_EVENT_FILTER_TYPE_CLOSE_EVENT is specified in GetWorkflowExecutionHistory call.
Why?
We had moved this logic to frontend service in the change #7179. But this will cause an issue when frontend service is downgraded to an earlier version.
Adding this logic in history until the next release. Will remove this after the next release.
How did you test it?
New unit test.
Potential risks
Documentation
Is hotfix candidate?
No