Add event ID to RequestIDInfo and request ID to CallbackInfo #7491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
force-pushed
the
rodrigozhou/request-id-to-event-id
branch
from
25341e9 to
b13745e
Compare
pdoerner
reviewed
Mar 19, 2025
| @@ -342,6 +343,7 @@ func (s *historyCurrentExecutionSuite) newRandomCurrentExecutionRow( | |||
| RequestIds: map[string]*persistencespb.RequestIDInfo{ | |||
| uuid.NewString(): { | |||
| EventType: enumspb.EVENT_TYPE_WORKFLOW_EXECUTION_OPTIONS_UPDATED, | |||
| EventId: common.FirstEventID, | |||
There was a problem hiding this comment.
should be common.BufferedEventID?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add event ID to
RequestIDInfoand request ID toCallbackInfo.Also added
RequestIdInfostoDescribeWorkflowExecutionResponse.Why?
Be able to identify the exact event that attached the callback to the workflow.
How did you test it?
Potential risks
Documentation
Is hotfix candidate?