Skip to content

Conversation

@Alex-Tideman
Copy link
Collaborator

Description & motivation 💭

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@vercel
Copy link

vercel bot commented Jan 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
holocene Ready Ready Preview, Comment Jan 12, 2026 6:14pm

workers: `/namespaces/${parameters?.namespace}/workers`,
worker: `/namespaces/${parameters?.namespace}/workers/describe/${parameters?.workerInstanceKey}`,
'worker-task-reachability': `/namespaces/${parameters?.namespace}/worker-task-reachability`,
'workflow.terminate': `/namespaces/${parameters?.namespace}/workflows/${parameters?.workflowId}/terminate`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ 'parameters' is possibly 'undefined'.
  • ⚠️ 'parameters' is possibly 'undefined'.

worker: `/namespaces/${parameters?.namespace}/workers/describe/${parameters?.workerInstanceKey}`,
'worker-task-reachability': `/namespaces/${parameters?.namespace}/worker-task-reachability`,
'workflow.terminate': `/namespaces/${parameters?.namespace}/workflows/${parameters?.workflowId}/terminate`,
'workflow.cancel': `/namespaces/${parameters.namespace}/workflows/${parameters.workflowId}/cancel`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ 'parameters' is possibly 'undefined'.
  • ⚠️ 'parameters' is possibly 'undefined'.
  • ⚠️ 'parameters' is possibly 'undefined'.

@temporal-cicd
Copy link
Contributor

temporal-cicd bot commented Jan 12, 2026

Warnings
⚠️

📊 Strict Mode: 40 errors in 3 files (14.4% of 278 total)

src/lib/utilities/route-for.ts (1)
  • L128:4: Type 'string | undefined' is not assignable to type 'string'.
src/lib/utilities/route-for-api.ts (36)
  • L64:48: Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.
  • L70:50: Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.
  • L72:4: Type 'string | null' is not assignable to type 'string'.
  • L99:8: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '{ namespace: string; workflowId: string; scheduleId: string; queue: string; queryType: string; signalName: string; updateName: string; batchJobId: string; runId: string; activityId: string; endpointId: string; deploymentName: string; version: string; workerInstanceKey: string; }'.
  • L99:38: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'Partial'.
  • L101:8: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '{ namespace: string; workflowId: string; scheduleId: string; queue: string; queryType: string; signalName: string; updateName: string; batchJobId: string; runId: string; activityId: string; endpointId: string; deploymentName: string; version: string; workerInstanceKey: string; }'.
  • L101:57: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'Partial'.
  • L129:40: Argument of type 'Partial | undefined' is not assignable to parameter of type 'Partial'.
  • L136:40: 'parameters' is possibly 'undefined'.
  • L140:93: 'parameters' is possibly 'undefined'.
  • L154:38: 'parameters' is possibly 'undefined'.
  • L154:72: 'parameters' is possibly 'undefined'.
  • L155:38: 'parameters' is possibly 'undefined'.
  • L155:72: 'parameters' is possibly 'undefined'.
  • L155:104: 'parameters' is possibly 'undefined'.
  • L156:38: 'parameters' is possibly 'undefined'.
  • L156:72: 'parameters' is possibly 'undefined'.
  • L156:104: 'parameters' is possibly 'undefined'.
  • L157:37: 'parameters' is possibly 'undefined'.
  • L157:71: 'parameters' is possibly 'undefined'.
  • L162:40: 'parameters' is possibly 'undefined'.
  • L163:36: 'parameters' is possibly 'undefined'.
  • L164:37: 'parameters' is possibly 'undefined'.
  • L165:39: 'parameters' is possibly 'undefined'.
  • L166:37: 'parameters' is possibly 'undefined'.
  • L167:46: 'parameters' is possibly 'undefined'.
  • L168:44: 'parameters' is possibly 'undefined'.
  • L169:39: 'parameters' is possibly 'undefined'.
  • L171:42: 'parameters' is possibly 'undefined'.
  • L172:49: 'parameters' is possibly 'undefined'.
  • L173:41: 'parameters' is possibly 'undefined'.
  • L174:40: 'parameters' is possibly 'undefined'.
  • L174:83: 'parameters' is possibly 'undefined'.
  • L175:48: 'parameters' is possibly 'undefined'.
  • L175:99: 'parameters' is possibly 'undefined'.
  • L181:16: This overload signature is not compatible with its implementation signature.
src/lib/utilities/screaming-enums.ts (3)
  • L84:14: Type 'undefined' is not assignable to type 'PendingActivityState'.
  • L91:14: Type 'PendingNexusOperationState.PENDING_NEXUS_OPERATION_STATE_UNSPECIFIED | undefined' is not assignable to type 'PendingNexusOperationState'.
  • L98:14: Type 'CallbackState.CALLBACK_STATE_UNSPECIFIED | undefined' is not assignable to type 'CallbackState'.

Generated by 🚫 dangerJS against 567aa2d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants