Nav update icons clean #3095
Open
Nav update icons clean #3095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add buildings.svelte icon for organizations/projects - Add cube.svelte icon for deployments/packages - Remove unused identities-icon.svelte - Update icon registry in paths.ts 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Cloud with subtitle: uses push icon and new layout - Self-Hosted / Cloud without subtitle: uses chevron icon and standard layout - Maintains backward compatibility for UI/Core - Supports new subtitle functionality for Cloud repo 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Convert from slot syntax to Svelte 5 snippet syntax - Update Navigation to use children and bottom snippets - Update SideNavigation to pass snippets instead of slots - Update layout to use snippet syntax for bottom nav item Fixes Vite/Svelte compilation error about mixing slot and render tags 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Addresses code review feedback to separate navigation logic into distinct components instead of using conditional rendering. - Create CloudNavBar component for Cloud nav with subtitle/push icon - Create OSSNavBar component for Self-Hosted nav with chevron icon - Update navigation-container to delegate to appropriate component - Improves code maintainability and component reusability 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Contributor
andrewzamojc
left a comment
andrewzamojc
left a comment
There was a problem hiding this comment.
Looks pretty good. I left a couple comments.
| {#if item.divider} | ||
| <hr class="-mx-4 my-4 border-subtle" /> | ||
| <Navigation {isCloud} {bottom} aria-label={translate('common.primary')}> | ||
| {#snippet children()} |
Contributor
There was a problem hiding this comment.
Nit: Children snippet is implicit, so you don't need this line {#snippet children()}. https://svelte.dev/docs/svelte/snippet#Passing-snippets-to-components-Implicit-children-snippet
| class="self-center justify-self-center py-3 text-center text-[0.6rem] text-slate-300" | ||
| > | ||
| <span class="sr-only">{translate('common.version')}</span> | ||
| {#if isCloud && subtitle} |
Contributor
There was a problem hiding this comment.
Question: Should subtitle be part of this if check? If isCloud is true, but subtitle happens to be blank, shouldn't it still render the CloudNavBar just with an blank subtitle='' ?
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nav Container Update
This PR is meant to add the underlying structure for the new nav.
Add new navigation icons
Adds buildings and cube icons to the Holocene icon library for use in
navigation updates.
Changes
subtitle/push icon) and Self-Hosted (with chevron icon) layouts
snippet syntax for compatibility
Technical Notes