-
Notifications
You must be signed in to change notification settings - Fork 140
feat(navigation): add NavSection Holocene component #3263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KATIETOLER
wants to merge
14
commits into
main
Choose a base branch
from
nav-groups/kt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
35dc710
feat(navigation): add NavGroup Holocene component
KATIETOLER 726e09d
Fix: type errors
KATIETOLER 50f85ce
feat(navigation): extend NavGroup to OSS and split nav groups
KATIETOLER 77de183
refactor(navigation): tighten NavGroup to NavLinkItem[]
KATIETOLER bb56b0e
refactor(navigation): split getLinkList into explicit nav groups
KATIETOLER 4002f92
refactor(navigation): rename NavGroup to NavSection, sections API
KATIETOLER dbcdd94
feat(navigation): add secondaryLinkList prop to BottomNavigation and …
KATIETOLER 72b1894
fix(navigation): pass secondary nav links to BottomNavigation for mob…
KATIETOLER c327036
fix(navigation): add keyed iterators to bottom-nav-links each blocks
KATIETOLER 261eab2
Update bottom nav to svelte5.
KATIETOLER df05531
refactor(navigation): remove NavLinkListItem alias, use NavLinkItem d…
KATIETOLER 63338e2
refactor(navigation): migrate bottom-nav to sections API and Svelte 5
KATIETOLER fa38313
Fix: rename import to match new type name.
KATIETOLER ca80cf4
Refactor: remove unused nav utils file.
KATIETOLER File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <script lang="ts"> | ||
| import type { NavLinkItem } from '$lib/types/global'; | ||
|
|
||
| import NavigationItem from './navigation-item.svelte'; | ||
|
|
||
| interface Props { | ||
| navItems: NavLinkItem[]; | ||
| } | ||
|
|
||
| let { navItems }: Props = $props(); | ||
| </script> | ||
|
|
||
| {#each navItems as item} | ||
| <NavigationItem | ||
| link={item.href} | ||
| label={item.label} | ||
| icon={item.icon} | ||
| tooltip={item.tooltip || item.label} | ||
| external={item.external} | ||
| animate={item.animate} | ||
| isActive={item.isActive} | ||
| /> | ||
| {/each} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.