Workflows Table Row Density#3285
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
The design team is currently doing our own table density work to make sure everything plays nice for all the various types of styles we have in our tables, as well as adjusting sizing of components within tables that will impact table row height and truncation. We definitely want to tackle this but we want to make sure we're covering all our bases so this can become a pattern across the board for all high density tables. We already have "All/Compact" and then adding a "Compact/Comfy" may start crossing some boundaries we want to care for preemptively. Can we pause on this while the UX team wraps up our discovery and comparison and then we'll come back with a comprehensive plan for how a compact/comfy treatment will work across all tables in the UI? This would be an excellent candidate for a UX/Eng collaborative pairing. Noting some things that this would cover:
|
| @@ -71,6 +72,7 @@ | |||
| workflowId={workflow.id} | |||
There was a problem hiding this comment.
⚠️ 'workflow' is possibly 'undefined'.⚠️ Type 'string | undefined' is not assignable to type 'string'.
| @@ -71,6 +72,7 @@ | |||
| workflowId={workflow.id} | |||
| taskQueue={workflow.taskQueue} | |||
There was a problem hiding this comment.
⚠️ 'workflow' is possibly 'undefined'.
| class={$tableDensity === 'compact' ? 'mt-1 h-5 w-5' : ''} | ||
| > | ||
| <Tooltip | ||
| text={childrenShown |
There was a problem hiding this comment.
⚠️ Argument of type '{ count: number | undefined; }' is not assignable to parameter of type 'I18nReplace'.
|
…ither side for better readability
…o allow for a little more space
| <td | ||
| class="workflows-summary-table-body-cell filterable" | ||
| class="workflows-summary-table-body-cell" | ||
| class:filterable={!truncate} |
There was a problem hiding this comment.
Yeah was thinking about this, but if you don't have many columns, you aren't going to use Dense mode. I don't want to add a bunch of complexity here when its not really the point of the mode to use when you just have a couple of columns.
| @@ -165,6 +190,7 @@ | |||
| attribute={label} | |||
There was a problem hiding this comment.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
Auto-generated version bump from 2.48.3 to 2.48.4 Specific version: 2.48.4 Changes included: - [`7cf1be53`](7cf1be5) Adjust breadcrumb spacing and min-height (#3304) - [`c9834815`](c983481) Add missing Nexus Operation events to event groups (#3309) - [`5c7aa86c`](5c7aa86) feat: add onItemsChange callback to PaginatedTable (#3300) - [`66d3cf68`](66d3cf6) Update pre-release badge to secondary in Workers (#3310) - [`393e84de`](393e84d) Keep Pending Activities/Operations at the top of Timeline and Compact view (#3307) - [`9f721347`](9f72134) Update error link in codec-server-error-banner (#3313) - [`e698bda3`](e698bda) Add class prop to BottomNav component (#3314) - [`55767fc9`](55767fc) Add overrides (#3317) - [`256cd274`](256cd27) refactor(decode-payload): clean up decode-payload.ts API surface (#3302) - [`04f8c251`](04f8c25) Make input height full so its easier to click into the input (#3318) - [`b2231056`](b223105) Workflows Table Row Density (#3285) - [`0b2ce4fd`](0b2ce4f) PR Review Notifications (#3322) - [`84618196`](8461819) feat: serverless worker deployment CRUD (#3236) Co-authored-by: rossnelson <146089+rossnelson@users.noreply.github.com>

Description & motivation 💭
Reduce the whitespace in the Workflows List to allow users to more quickly scan information, especially if they have configured lots of columns.
Summary
Test plan
Screenshots (if applicable) 📸
Dense.ComfyQuick.mov
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?