WIP - download external payloads#3345
Draft
rossedfort wants to merge 3 commits intorefactor-payload-componentfrom
Draft
WIP - download external payloads#3345rossedfort wants to merge 3 commits intorefactor-payload-componentfrom
rossedfort wants to merge 3 commits intorefactor-payload-componentfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Adds download functionality for externally stored payloads (note: only for payloads that display in a Code Block). Other payload touch points will be addressed in a following PR.
WIP

This PR is a work in progress. Currently the download button shows, but the download functionality doesn't work.
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
pnpm iandpnpm build:serverandpnpm devExternal Storage Bug Bash 04/17AWS_PROFILEandS3_BUCKETenvironment variablesgo run demos/worker/main.go, and in a separate shell session, rungo run demos/codecserver/main.gotemporal workflow start --task-queue "echo-task-queue" --type "GenerateDocument" --workflow-id "generate-doc" --input '1000000'to run a workflow with an externally stored payload.Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?