Skip to content

refactor(DT-3906): Add knip#3350

Merged
tegan-temporal merged 3 commits intomainfrom
add-knip
Apr 29, 2026
Merged

refactor(DT-3906): Add knip#3350
tegan-temporal merged 3 commits intomainfrom
add-knip

Conversation

@tegan-temporal
Copy link
Copy Markdown
Contributor

@tegan-temporal tegan-temporal commented Apr 28, 2026

Description & motivation 💭

Before starting the larger work of migrating Svelte 4 syntax to Svelte 5, I wanted to add and configure Knip to help monitor dead code and unused dependancies. As you can see from the PR we have a number of unused dependencies.

In the future we might want to add Knip to the dangerfile or CI so we can ensure dead code is cleaned up as we go.

Screenshots (if applicable) 📸

❯ pnpm knip

> @temporalio/ui@2.49.1 knip /Users/tegan/Projects/ui
> knip

Unused dependencies (1)
lodash.groupby             package.json:113:6
Unused devDependencies (30)
@babel/preset-typescript          package.json:127:6
@grpc/grpc-js                     package.json:130:6
@storybook/addon-docs             package.json:134:6
@storybook/blocks                 package.json:140:6
@storybook/icons                  package.json:141:6
@temporalio/testing               package.json:154:6
@types/base-64                    package.json:157:6
@types/mkdirp                     package.json:161:6
@types/sanitize-html              package.json:163:6
@types/unist                      package.json:165:6
@typescript-eslint/eslint-plugin  package.json:167:6
@typescript-eslint/parser         package.json:168:6
c8                                package.json:172:6
chalk                             package.json:173:6
ejs                               package.json:177:6
esbuild                           package.json:178:6
google-protobuf                   package.json:190:6
mock-socket                       package.json:198:6
npm-run-all                       package.json:201:6
postcss-cli                       package.json:204:6
postcss-import                    package.json:206:6
react-dom                         package.json:212:6
rehype-document                   package.json:213:6
rehype-format                     package.json:214:6
rehype-stringify                  package.json:215:6
svelte-eslint-parser              package.json:227:6
svelte-highlight                  package.json:228:6
svelte-loader                     package.json:229:6
tslib                             package.json:234:6
webpack                           package.json:242:6
Unlisted dependencies (1)
@vitest/coverage-v8  vitest.config.ts
Unresolved imports (2)
../../src/theme/colors  scripts/audit-tailwind-colors/utilities.ts:4:20         
../../types/global      src/lib/utilities/write-actions-are-allowed.test.ts:6:31

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s)

DT-3906

Docs

Any docs updates needed?

@tegan-temporal tegan-temporal self-assigned this Apr 28, 2026
@tegan-temporal tegan-temporal requested a review from a team as a code owner April 28, 2026 22:12
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Apr 28, 2026 10:12pm

Request Review

Copy link
Copy Markdown
Collaborator

@rossnelson rossnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No harm in adding this, thanks! Looks like it has nice config for ignores as well in case things get too noisy in the future.

@tegan-temporal tegan-temporal merged commit d424a78 into main Apr 29, 2026
20 checks passed
@tegan-temporal tegan-temporal deleted the add-knip branch April 29, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants