Fix null conditionals in search attribute filter#3351
Merged
laurakwhit merged 2 commits intomainfrom Apr 29, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| @@ -326,7 +326,7 @@ | |||
| active={localFilter.conditional === option.value} | |||
| on:click={() => { | |||
| if (isNullConditional(option.value)) { | |||
Contributor
There was a problem hiding this comment.
⚠️ Type 'null' is not assignable to type 'string'.
Contributor
|
GraceGardner
approved these changes
Apr 29, 2026
Contributor
GraceGardner
left a comment
GraceGardner
left a comment
There was a problem hiding this comment.
Thanks for getting this in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
When selecting
Is null/Is not nullin the Workflow search attribute filter it should now create the correct query. The filter was either being dropped (becausevalue === '') or emitting a malformed statement with the empty value interpolated in it.Behavior was introduced when value was set to empty string here.
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Go to
/workflows>+ Add Filter> select aKeywordsearch attributeIs nulland verify it updates the query correctlyIs not nulland verify it updates the query correctlyChecklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?