chore: ensure the empty app.html respects the user's light/dark settings#3353
Open
fidiego wants to merge 1 commit intotemporalio:mainfrom
Open
chore: ensure the empty app.html respects the user's light/dark settings#3353fidiego wants to merge 1 commit intotemporalio:mainfrom
fidiego wants to merge 1 commit intotemporalio:mainfrom
Conversation
this is useful during the brief moment during which the html has loaded but the app js hasn't finished loading and executing. it prevents users from seeing a glaring bright screen which is an undesirable experience in the wee hours of the morning.
|
@fidiego is attempting to deploy a commit to the Temporal Team on Vercel. A member of the Team first needs to authorize it. |
|
|
fidiego
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
The
app.htmlrenders before the svelte app. This can persist for a few seconds. However, this bare htmldoesn't respect the system's light/dark settings. This change prevents users from seeing a glaring bright screen
which is an undesirable experience in the wee hours of the morning.
Screenshots (if applicable) 📸
Design Considerations 🎨
The html page uses the same bg color (
#141414) used in the css throughout this codebase.Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Issue(s) closed
No related issue.
Docs
No documentation updates required.