refactor(DT-3906): Update components/event components to Svelte 5 syntax#3360
Closed
tegan-temporal wants to merge 0 commit intocodefreeze-05.01.26from
Closed
refactor(DT-3906): Update components/event components to Svelte 5 syntax#3360tegan-temporal wants to merge 0 commit intocodefreeze-05.01.26from
tegan-temporal wants to merge 0 commit intocodefreeze-05.01.26from
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Base automatically changed from
DT-3906-ui-svelte-5-migration
to
codefreeze-05.01.26
May 1, 2026 17:06
tegan-temporal
force-pushed
the
DT-3906-ui-svelte-5-migration-2
branch
from
a752c8c to
7bbf2af
Compare
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| ? options.filter((o) => $eventCategoryFilter.includes(o.value)) | ||
| : [], | ||
| ); | ||
|
|
Contributor
There was a problem hiding this comment.
⚠️ Parameter '_options' implicitly has an 'any' type.
| const resolvedHref = $derived(href ?? getEventLinkHref(link)); | ||
| const resolvedValue = $derived( | ||
| value ?? | ||
| (resolvedHref.split('workflows/')?.[1] || resolvedHref) ?? |
Contributor
There was a problem hiding this comment.
⚠️ 'link.workflowEvent' is possibly 'null' or 'undefined'.
Contributor
|
GraceGardner
reviewed
May 4, 2026
Contributor
GraceGardner
left a comment
GraceGardner
left a comment
There was a problem hiding this comment.
Some weird flags that popped up about undefined and such that might be worth a look before merging? Happy to approve when you're ready though
Comment on lines
+10
to
+28
| export let href: string | undefined = undefined; | ||
|
|
||
| $: if (!href) { | ||
| href = getEventLinkHref(link); | ||
| value = href.split('workflows/')?.[1] || href; | ||
| interface Props { | ||
| link: EventLink; | ||
| value?: string; | ||
| label?: string; | ||
| href?: string; | ||
| class?: string; | ||
| linkClass?: string; | ||
| } | ||
|
|
||
| let { | ||
| link, | ||
| value, | ||
| label = translate('nexus.link'), | ||
| href, | ||
| class: className = '', | ||
| linkClass = '', | ||
| }: Props = $props(); | ||
|
|
||
| const resolvedHref = $derived(href ?? getEventLinkHref(link)); | ||
| const resolvedValue = $derived( | ||
| value ?? | ||
| (resolvedHref.split('workflows/')?.[1] || resolvedHref) ?? |
Contributor
There was a problem hiding this comment.
Did you already look into this? I can see why you would have removed the null/undefined stuff. Not sure why we would be using this component in a case where this is undefined? But might want to just make sure that removing that is safe? Which you may have already done?
tegan-temporal
force-pushed
the
DT-3906-ui-svelte-5-migration-2
branch
from
7bbf2af to
23d7cfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Update components/event components to Svelte 5 syntax