refactor(DT-3906): Update components/workflow to Svelte 5 syntax#3361
Merged
tegan-temporal merged 1 commit intocodefreeze-05.01.26from May 4, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tegan-temporal
changed the base branch from
DT-3906-ui-svelte-5-migration-2
to
codefreeze-05.01.26
tegan-temporal
force-pushed
the
DT-3906-ui-svelte-5-migration-3
branch
from
834b6ab to
026486f
Compare
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| const resolvedHref = $derived(href ?? getEventLinkHref(link)); | ||
| const resolvedValue = $derived( | ||
| value ?? | ||
| (resolvedHref.split('workflows/')?.[1] || resolvedHref) ?? |
Contributor
There was a problem hiding this comment.
Did you check this undefined thing won't break things?
Contributor
|
GraceGardner
reviewed
May 4, 2026
Contributor
GraceGardner
left a comment
GraceGardner
left a comment
There was a problem hiding this comment.
Let me know if you confirmed that the possible undefined stuff won't break anything. Will stamp when you're ready :)
| const resolvedHref = $derived(href ?? getEventLinkHref(link)); | ||
| const resolvedValue = $derived( | ||
| value ?? | ||
| (resolvedHref.split('workflows/')?.[1] || resolvedHref) ?? |
Contributor
There was a problem hiding this comment.
Did you check this undefined thing won't break things?
tegan-temporal
force-pushed
the
DT-3906-ui-svelte-5-migration-3
branch
from
026486f to
311d759
Compare
tegan-temporal
force-pushed
the
DT-3906-ui-svelte-5-migration-3
branch
from
311d759 to
3b02d64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Updates component/workflow components to Svelte 5 syntax.