refactor(DT-3906): More Svelte 5 Migrations (trivial ones)#3364
Merged
tegan-temporal merged 7 commits intocodefreeze-05.01.26from May 4, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| ? options.filter((o) => $eventClassificationFilter.includes(o.value)) | ||
| : [], | ||
| ); | ||
|
|
Contributor
There was a problem hiding this comment.
⚠️ Parameter '_options' implicitly has an 'any' type.
| const workflowEvents = $derived( | ||
| getWorkflowStartedCompletedAndTaskFailedEvents($fullEventHistory), | ||
| ); | ||
| const isPending = $derived( |
Contributor
There was a problem hiding this comment.
⚠️ '$workflowRun.workflow' is possibly 'null'.⚠️ '$workflowRun.workflow' is possibly 'null'.
|
|
||
| $: canceled = ['Terminated', 'TimedOut', 'Canceled'].includes( | ||
| workflow?.status, | ||
| const canceled = $derived( |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'string | null | undefined' is not assignable to parameter of type 'string'.
| ['Terminated', 'TimedOut', 'Canceled'].includes(workflow?.status), | ||
| ); | ||
| </script> | ||
|
|
Contributor
There was a problem hiding this comment.
⚠️ 'pendingActivities' is possibly 'undefined'.
Contributor
|
laurakwhit
reviewed
May 4, 2026
…le (#3344) * Fix eslint warning * Migrate to Svelte 5 syntax * Add multiselect via shift key * Clear prev index after page selected or all selected trigger * Make onClickBatchSelect optional, disable checkbox if child * Do not set child disabled * Support shift+click select within child workflows * Update shift+click logic. Instead of multiple scopes, treat all visible items as one scope. * Remove console log * Fixup type * Add tests * Account for prevClickedRow being nullish * Fix type * Fix some warnings * Fix type * Fix type for onClickBatchSelect * Fix type check * Use early return * More warning fixes * Undo prop type change * Fix warning * Default query to empty string * Move comment to inside handler :\ * Move isChecked higher * Fix race condition * Fix the fix :P * Use runId as key * use runId for check * Show root rows as checked if allSelected * Use map instead of set so we rely on runId for equality * Fix header checkmark status * Address PR comments * Apply suggestions from code review Co-authored-by: Laura Whitaker <laura.k.whitaker@gmail.com> --------- Co-authored-by: Laura Whitaker <laura.k.whitaker@gmail.com>
laurakwhit
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates a bunch of components and routes from Svelte 4 legacy syntax to Svelte 5 runes. This batch is scoped to "trivial" components -- ones with straightforward props/event handler conversions and no complex reactivity, slot forwarding, or two-way bindings worth calling out.