Skip to content

refactor(DT-3906): More trivial migrations#3367

Open
tegan-temporal wants to merge 4 commits intocodefreeze-05.01.26from
DT-3906-ui-svelte-5-migrate-trivial
Open

refactor(DT-3906): More trivial migrations#3367
tegan-temporal wants to merge 4 commits intocodefreeze-05.01.26from
DT-3906-ui-svelte-5-migrate-trivial

Conversation

@tegan-temporal
Copy link
Copy Markdown
Contributor

Description & motivation 💭

Should be the last of the "trivial" legacy syntax to runes syntax migrations

@tegan-temporal tegan-temporal self-assigned this May 4, 2026
@tegan-temporal tegan-temporal requested a review from a team as a code owner May 4, 2026 21:56
@vercel
Copy link
Copy Markdown

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment May 4, 2026 10:30pm

Request Review

@temporal-cicd
Copy link
Copy Markdown
Contributor

temporal-cicd Bot commented May 4, 2026

Warnings
⚠️

📊 Strict Mode: 14 errors in 7 files (1.4% of 975 total)

src/lib/components/batch-operations/header.svelte (1)
  • L60:19: Argument of type '(event: Event & { target: EventTarget & HTMLInputElement; }) => void' is not assignable to parameter of type '(e: Event) => void'.
src/lib/components/import/event-history-file-import.svelte (1)
  • L44:8: Argument of type 'HistoryEvent[] | undefined' is not assignable to parameter of type 'HistoryEvent[]'.
src/lib/components/search-attribute-filter/filter-list.svelte (1)
  • L48:6: Type 'null' is not assignable to type 'number'.
src/lib/components/search-attribute-filter/status-filter.svelte (3)
  • L109:24: Argument of type 'string | null' is not assignable to parameter of type 'string'.
  • L116:12: Type '"All" | WorkflowStatus' is not assignable to type 'string | undefined'.
  • L114:42: Argument of type 'string | null' is not assignable to parameter of type 'string'.
src/lib/components/workflow/workflow-relationships-old.svelte (4)
  • L45:9: Type 'string | undefined' is not assignable to type 'string'.
  • L46:9: Type 'string | undefined' is not assignable to type 'string'.
  • L47:9: Type 'string | undefined' is not assignable to type 'string'.
  • L59:25: '$workflowRun.workflow' is possibly 'null'.
src/lib/components/workflow/relationships/workflow-family-tree.svelte (2)
  • L52:8: Type 'string | null | undefined' is not assignable to type 'string'.
  • L53:8: Type 'string | null | undefined' is not assignable to type 'string | undefined'.
src/lib/holocene/toaster.svelte (2)
  • L44:40: Type 'ToastVariant | undefined' is not assignable to type 'ToastVariant'.
  • L44:50: Type 'string | undefined' is not assignable to type 'string'.

Generated by 🚫 dangerJS against 6874efa

const filteredGroups = $derived(
getFailedOrPendingGroups(groups, $eventStatusFilter),
);
const firstStartTime = $derived(
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a preexisting error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant