Skip to content

feat: add Stellar charge intent method spec#199

Merged
brendanjryan merged 6 commits intotempoxyz:mainfrom
marcelosalloum:feat/add-stellar-method
Mar 29, 2026
Merged

feat: add Stellar charge intent method spec#199
brendanjryan merged 6 commits intotempoxyz:mainfrom
marcelosalloum:feat/add-stellar-method

Conversation

@marcelosalloum
Copy link
Copy Markdown
Contributor

What

  • Add draft-stellar-charge-00.md defining the stellar payment method with charge intent for SEP-41 token transfers on the Stellar smart contracts
  • Support server-sponsored fees (feePayer: true) and client-paid fees (feePayer: false)
  • Add settlement-failed error code to the core httpauth-payment spec for post-verification on-chain failures

Why

Enables Stellar blockchain payments through the MPP Payment HTTP Authentication Scheme, covering SEP-41 token transfers with optional fee sponsorship.

The settlement-failed error code fills a gap in the core spec where valid credentials can still fail at settlement (e.g., insufficient funds on-chain), distinct from verification-failed which indicates an invalid proof.

@marcelosalloum marcelosalloum marked this pull request as ready for review March 21, 2026 00:37
@brendanjryan
Copy link
Copy Markdown
Collaborator

Thanks for submitting! Left a few high level comments and will take a deeper look in the next few days

@marcelosalloum marcelosalloum force-pushed the feat/add-stellar-method branch from 3861689 to 83be166 Compare March 24, 2026 20:41
@marcelosalloum marcelosalloum force-pushed the feat/add-stellar-method branch from 83be166 to ae7e886 Compare March 24, 2026 20:42
@marcelosalloum
Copy link
Copy Markdown
Contributor Author

@brendanjryan: thanks for the review. I've addressed your comments and rebased the PR on main.

Copy link
Copy Markdown
Collaborator

@brendanjryan brendanjryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for submitting!

Do you want to add docs to tempoxyz/mpp for the stellar SDK as well?

@github-actions
Copy link
Copy Markdown

Spec Preview

Spec Changed
draft-card-charge-00 Yes
draft-httpauth-payment-00 Yes
draft-lightning-charge-00 Yes
draft-lightning-session-00 Yes
draft-payment-discovery-00 Yes
draft-payment-intent-charge-00 Yes
draft-payment-transport-mcp-00 Yes
draft-solana-charge-00 Yes
draft-stellar-charge-00 -
draft-stripe-charge-00 Yes
draft-tempo-charge-00 Yes
draft-tempo-session-00 Yes

Download spec artifacts (HTML, TXT, XML, PDF)

@brendanjryan brendanjryan merged commit b8c42d1 into tempoxyz:main Mar 29, 2026
2 checks passed
@marcelosalloum marcelosalloum deleted the feat/add-stellar-method branch March 30, 2026 16:51
@marcelosalloum
Copy link
Copy Markdown
Contributor Author

Do you want to add docs to tempoxyz/mpp for the stellar SDK as well?

Sure thing, I'll be adding a PR there shortly.

@brendanjryan
Copy link
Copy Markdown
Collaborator

🙇

@oceans404
Copy link
Copy Markdown

LGTM! Thank you for submitting!

Do you want to add docs to tempoxyz/mpp for the stellar SDK as well?

Hey @brendanjryan! We've added docs to tempoxyz/mpp on this PR: tempoxyz/mpp#513 Could you review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants