Conversation
Bundle Size Report
Chunk changes (>1KB)
Compared against main branch (baseline from 4/27/2026, 4:02:54 PM) |
Cloudflare Deployments
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ceede74483
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Follow-up pushed in 0024bee. Addresses Codex review comments:
Also kept RPC changes local to Explorer: server-side wagmi now uses the proxy RPC URL with key plus the normal RPC URL with key via the existing load balancer/rate limiter; no shared |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0024bee189
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| recentParticipants.length >= | ||
| HOLDERS_RECENT_PARTICIPANT_FULL_QUERY_THRESHOLD | ||
| ) { | ||
| allHolders = await fetchRecentHolderBalances({ |
There was a problem hiding this comment.
Do not skip full holder aggregation on activity heuristic
This branch turns the “recent participant” path into the primary path whenever activity is high, so allHolders is built from a small candidate set instead of the full transfer-derived holder set. Because candidates are limited to recent addresses, tokens with many older/inactive holders will return incomplete holder lists and inaccurate totals/pagination metadata even when fetchTokenHolderBalances would succeed, which is a correctness regression rather than a true fallback.
Useful? React with 👍 / 👎.
|
Addressed discussion_r3152152874 in 47987c3. The holders endpoint now tries full transfer-derived aggregation first on cache miss, and only uses the recent-participant balanceOf path if full aggregation fails. That keeps recent participants as a true fallback rather than using activity as a correctness-changing heuristic. Verified with:
Also rechecked the PathUSD holders URL locally; it still renders holder rows via fallback when full aggregation fails. |
|
Also fixed the noisy unverified contract source response in f9d8db4. Verified with:
|
|
Follow-up for PathUSD holder totals pushed in b55a0aa. The fallback path is not an exact holder-count source; it samples recent transfer participants and reads balances because full TIDX aggregation is failing. So the UI should not render Now the holders response carries Also checked kitty pane 9: it is still showing TIDX 422s for the full holder aggregation ( |
Summary
balanceOfvalues and sorts positive balancesValidation