fix(transaction): copy AwaitingFeePayer in Tx.Clone()#65
Closed
CrytoInsight wants to merge 2 commits into
Closed
Conversation
Collaborator
|
Thanks for the PR! Rolled fwd with your commits in the linked PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(transaction): copy AwaitingFeePayer in Tx.Clone()
Summary
Tx.Clone()copied every field of the transaction exceptAwaitingFeePayer. Forsponsored (fee-payer) transactions this silently changes the bytes the sender signs,
so a signature produced over a clone never verifies on chain.
Root cause
SerializeForSigningbranches onAwaitingFeePayer:When the flag is true the signing payload (a) skips
fee_tokenand (b) writes the0x00fee-payer marker in field 11.Clone()left the flag at its zero value(
false), so the clone serialized to the non-sponsored form instead.Impact
for sponsored transactions is broken, and the failure is silent until broadcast.
Clone()is explicitly documented for producing transaction variations, so this ison the happy path.
Fix
Add the missing field to the struct literal in
Clone():Verification
TestClonePreservesAwaitingFeePayerasserts the original and the clone produce anidentical signing hash. Fails before the change, passes after.
go test ./pkg/transaction/is green.