Skip to content

chore: fix tests for dev/test net#9

Merged
emmajam merged 4 commits intomainfrom
sdk-sync/add-devnet-testnet-ci
Jan 28, 2026
Merged

chore: fix tests for dev/test net#9
emmajam merged 4 commits intomainfrom
sdk-sync/add-devnet-testnet-ci

Conversation

@emmajam
Copy link
Copy Markdown
Member

@emmajam emmajam commented Jan 28, 2026

No description provided.

Emma Jamieson-Hoare and others added 3 commits January 28, 2026 19:11
- Add GetChainID method to client for eth_chainId RPC call
- Update integration tests to fetch chain ID from RPC instead of hardcoding 1337
- Add conditions to skip devnet/testnet CI jobs when secrets aren't configured

Amp-Thread-ID: https://ampcode.com/threads/T-019c0620-4204-754e-bfd4-65b5d5f6c2fb
Co-authored-by: Amp <amp@ampcode.com>
@emmajam emmajam marked this pull request as ready for review January 28, 2026 20:05
@emmajam emmajam merged commit ab8c611 into main Jan 28, 2026
4 checks passed
@emmajam emmajam deleted the sdk-sync/add-devnet-testnet-ci branch January 28, 2026 20:07
Copy link
Copy Markdown
Collaborator

@brendanjryan brendanjryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants