Skip to content
This repository was archived by the owner on Jun 11, 2026. It is now read-only.

fix: preserve fee token in fee payer signing#184

Closed
brendanjryan wants to merge 1 commit into
mainfrom
brendanjryan/fix-fee-payer-token
Closed

fix: preserve fee token in fee payer signing#184
brendanjryan wants to merge 1 commit into
mainfrom
brendanjryan/fix-fee-payer-token

Conversation

@brendanjryan

@brendanjryan brendanjryan commented Jun 11, 2026

Copy link
Copy Markdown

Summary

  • Preserve the configured chain fee token when the fee payer handler co-signs sponsored transactions
  • Add regression coverage for raw transaction sponsorship output
  • Add a patch changeset

mppx impact

mppx pull mode submits a user-signed sponsored Tempo transaction to the hosted fee payer. Sponsored sender signatures intentionally omit feeToken, so the fee payer must choose and include the fee token when it co-signs. The handler was deserializing the raw transaction and signing it without restoring client.chain.feeToken, producing a final sponsored envelope with a fee payer signature but no fee token. That causes mppx settlement/broadcast to fail during Tempo fee validation because the fee token path is missing or wrong.

@brendanjryan brendanjryan force-pushed the brendanjryan/fix-fee-payer-token branch from c61584f to 33251f4 Compare June 11, 2026 04:05
@pkg-pr-new

pkg-pr-new Bot commented Jun 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/tempoxyz/tempo-ts/tempo.ts@184

commit: 33251f4

@brendanjryan brendanjryan marked this pull request as ready for review June 11, 2026 04:08

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 33251f4920

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/server/Handler.ts
const serializedTransaction = await signTransaction(client, {
...transaction,
account,
...(feeToken ? { feeToken } : {}),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve explicit null fee token settings

When the fee payer client is configured with chain.extend({ feeToken: null }) to opt into protocol-selected fee tokens, this truthiness guard treats that explicit setting as absent. In that scenario, if the deserialized user transaction already contains a concrete feeToken, the earlier ...transaction spread keeps that token and the fee payer signs using it instead of preserving the configured null preference.

Useful? React with 👍 / 👎.

@brendanjryan

Copy link
Copy Markdown
Author

pulling this into accounts SDK re: archive notice

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant