Fix hardcoded RPC credentials in fee-amm test script - #7333
Open
callumweb3 wants to merge 1 commit into
Open
Conversation
## Summary Fix `ETH_RPC_URL` handling in `scripts/fee-amm-predeployed.sh`. [The script documented](https://github.com/tempoxyz/tempo/blob/main/scripts/fee-amm-predeployed.sh#L3) that it uses an existing `ETH_RPC_URL` or defaults to `localhost:8545`, but the previous implementation unconditionally overwrote the variable with a remote RPC URL containing credentials. The fix: * preserves an existing `ETH_RPC_URL`; * defaults to `http://localhost:8545` when it is not set; * removes the hardcoded RPC credentials from the script. No other script behavior was changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
ETH_RPC_URLhandling inscripts/fee-amm-predeployed.sh.The script documented that it uses an existing
ETH_RPC_URLor defaults tolocalhost:8545, but the previous implementation unconditionally overwrote the variable with a remote RPC URL containing credentials.The fix:
ETH_RPC_URL;http://localhost:8545when it is not set;No other script behavior was changed.