This repository was archived by the owner on Mar 18, 2019. It is now read-only.
Loggins for empty or non existing feature dir is added. Exeptions wil… #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l no longer be thrown.
mpkorstanje
reviewed
Dec 9, 2017
| @@ -190,13 +190,20 @@ | |||
| public void execute() throws MojoExecutionException { | |||
|
|
|||
| if (!featuresDirectory.exists()) { | |||
| throw new MojoExecutionException("Features directory does not exist"); | |||
| getLog().warn("Features directory does not exist"); | |||
There was a problem hiding this comment.
The resources plugin just informs us about skipping the non existing resources but does include the missing directory name. The first keeps the messages standardized, the latter is helpful.
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ simmetrics-example ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /home/mpkorstanje/Projects/SimMetrics/simmetrics/simmetrics-example/src/test/resources
So I think this should be skip non existing featuresDirectory /home/user/path/to/features
mpkorstanje
suggested changes
Dec 9, 2017
|
|
||
| createOutputDirIfRequired(); | ||
| if (featureFiles.isEmpty()) { | ||
| getLog().warn("Features directory is empty. No runners will be generated."); |
There was a problem hiding this comment.
Surefire informs us that there were no tests to run.
[INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ simmetrics-example ---
[INFO] No tests to run.
I think this should be No runners to generate.
It is also possible that when there are feature files, none generate runners due to a combination of tags. So I think this notification should be moved to the CucumberITGenerator implementations.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l no longer be thrown.
Test to support case when added feature dir has no features in it added;
Test for behavior when feature dir does not exist modified to check new scenario when exception is no longer thrown.