Add components #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for exquisite-pothos-d44e7c ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
yanislav-igonin
approved these changes
Nov 15, 2022
| @@ -1,31 +1,30 @@ | |||
| import { useState } from 'react' | |||
| import { useState, useEffect } from 'react' | |||
There was a problem hiding this comment.
Do not forget do delete unused code :)
|
|
||
| useEffect(() => { | ||
| getDetail(id).then(value => setPokemon(value)) | ||
| }); |
There was a problem hiding this comment.
Do not forget to add dependency array as a second argument
useEffect(() => {
getDetail(id).then(value => setPokemon(value))
}, [id]);
| let getDetail = async function(id: string): Promise<Pokemon> { | ||
| const ability = (await getOne(id)).data.abilities[0].ability.name; | ||
| const numId = parseInt(id); | ||
| const name = (await getList(numId - 1, 1)).data.results[0].name; |
There was a problem hiding this comment.
No need to make second request for one pokemon from the list, one can obtain name from the getOne request too.
|
|
||
| if (pokemon == undefined) { | ||
| return ( | ||
| <h1>Loading...</h1> |
There was a problem hiding this comment.
Like that you added loading placeholder, good job
|
|
||
| useEffect(() => { | ||
| getList(0, 9).then(values => setPosts(values.data.results)) | ||
| }) |
There was a problem hiding this comment.
Same here with dependencies array
useEffect(() => {
getList(0, 9).then(values => setPosts(values.data.results))
}, [])This will prevent infinite request calls.
| getList(0, 9).then(values => setPosts(values.data.results)) | ||
| }) | ||
|
|
||
| console.log('hmm') |
There was a problem hiding this comment.
Do not forget to remove logs, so they won't be in production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deployed Netlify app has a bug #1