Fix Pascal Conversion #424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data exported from CVAT to the Pascal VOC format does not have the truncated or pose fields. It also specifies coordinates using float values instead of ints. An earlier part of the code casts `obj['bndbox']['xmin']` to a float, so it seems valid to do this in the second place that accesses `obj['bndbox']['xmin']`, and just round this value. The behavior should be identical when values are ints. The behavior is identical when difficult and truncated fields are specified. However, this change also makes this code work correctly for files that do not contain these fields.
akindofyoga
requested review from
ziyeqinghan,
khanhlvg and
lu-wang-g
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data exported from CVAT to the Pascal VOC format does not have the truncated, difficult, or pose fields. It also specifies coordinates using float values instead of ints.
This code was casting
obj['bndbox']['xmin']to a float in one location, and then an int in another. The cast to an int would cause an error whenobj['bndbox']['xmin']contained a float value. This change rounds the float value, which makes the cast to an int successful. It does not change the code's behavior whenobj['bndbox']['xmin']has an int value.This change does not affect behavior when the difficult, truncated, and pose fields are specified. However, it makes the code work correctly for files that do not contain these fields.