Skip to content

Correct usage of max_number_of_boxes for TPU #8127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

waylonflinn
Copy link

Update TPU compatibility docs to show correct usage of max_number_of_boxes. Should be in train_config section instead of train_input_reader and eval_input_reader.

Correct usage can be seen in the following example TPU compatible config. This config is already linked to in this document.
https://github.com/tensorflow/models/blob/master/research/object_detection/samples/configs/ssd_resnet50_v1_fpn_shared_box_predictor_640x640_coco14_sync.config

Update TPU compatibility docs to show correct usage of max_number_of_boxes. Should be in train_config section instead of train_input_reader and eval_input_reader.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@waylonflinn
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jaeyounkim jaeyounkim added the models:research models that come under research directory label Apr 21, 2020
@jaeyounkim jaeyounkim added the stat:awaiting review Waiting on review label Apr 25, 2020
with zeros to a static shape. Padded groundtruth tensors are correctly
handled internally within the model.
Setting `max_number_of_boxes` to a large enough number in `train_config`
pads the groundtruth tensors with zeros to a static shape. Padded groundtruth
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not exceed 80 chars per line.

@jaeyounkim jaeyounkim added models:research:odapi ODAPI and removed models:research models that come under research directory labels Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants