Skip to content

Conversation

@st--
Copy link
Contributor

@st-- st-- commented Feb 19, 2021

Array-like behaviour for TransformedVariable.__eq__ and TransformedVariable.__ne__.
Resolves #1241.

@google-cla
Copy link

google-cla bot commented Feb 19, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Declares that the user has not signed CLA label Feb 19, 2021
@st-- st-- force-pushed the st--/transformed_variable_equality branch from df5c6ed to 647a2a0 Compare February 26, 2021 15:16
@google-cla
Copy link

google-cla bot commented Feb 26, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: yes Declares that the user has signed CLA and removed cla: no Declares that the user has not signed CLA labels Feb 26, 2021
@st--
Copy link
Contributor Author

st-- commented Feb 26, 2021

It's clearly not quite as simple as changing this one line, but I'd really appreciate thoughts from the tensorflow-probability core developers as to what else might need changing to get the tests to pass and be able to close #1241!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Declares that the user has signed CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TransformedVariable does not follow array convention for equality (==) comparison

2 participants