Skip to content

Remove the deprecated SetMaxMessageSize method #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hzy001
Copy link

@hzy001 hzy001 commented May 15, 2019

Signed-off-by: Hao Ziyu [email protected]

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@hzy001
Copy link
Author

hzy001 commented May 15, 2019

signed

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@hzy001
Copy link
Author

hzy001 commented May 16, 2019

signed

1 similar comment
@hzy001
Copy link
Author

hzy001 commented May 16, 2019

signed

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@hzy001
Copy link
Author

hzy001 commented Jun 14, 2019

updated

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@hzy001
Copy link
Author

hzy001 commented Jun 14, 2019

signed

2 similar comments
@hzy001
Copy link
Author

hzy001 commented Jun 14, 2019

signed

@hzy001
Copy link
Author

hzy001 commented Jun 14, 2019

signed

@hzy001
Copy link
Author

hzy001 commented Jun 14, 2019

updated

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@peddybeats peddybeats requested review from netfs August 11, 2019 22:07
@@ -303,7 +303,8 @@ Status Server::BuildAndStart(const Options& server_options) {
}
builder.RegisterService(model_service_.get());
builder.RegisterService(prediction_service_.get());
builder.SetMaxMessageSize(tensorflow::kint32max);
builder.SetMaxReceiveMessageSize(tensorflow::kint32max);
builder.SetMaxSendMessageSize(tensorflow::kint32max);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why set send message size limits? we just need to set max receive, given that
current method in grpc just sets this limit for SetMaxMessageSize() method:

https://github.com/grpc/grpc/blob/deaa8e16b3a9224a8447018008255cd7096d2443/include/grpcpp/server_builder.h#L205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants