-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Remove the deprecated SetMaxMessageSize method #1350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
signed |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
signed |
1 similar comment
signed |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
updated |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
signed |
2 similar comments
signed |
signed |
updated |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
…8_154033 Update version for 2.0.0 release.
@@ -303,7 +303,8 @@ Status Server::BuildAndStart(const Options& server_options) { | |||
} | |||
builder.RegisterService(model_service_.get()); | |||
builder.RegisterService(prediction_service_.get()); | |||
builder.SetMaxMessageSize(tensorflow::kint32max); | |||
builder.SetMaxReceiveMessageSize(tensorflow::kint32max); | |||
builder.SetMaxSendMessageSize(tensorflow::kint32max); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why set send message size limits? we just need to set max receive, given that
current method in grpc just sets this limit for SetMaxMessageSize() method:
Signed-off-by: Hao Ziyu [email protected]