-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add command-line flags to set model memory limit #1561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samikama
wants to merge
1
commit into
tensorflow:master
Choose a base branch
from
samikama:model_memory_limit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,7 @@ limitations under the License. | |
#define TENSORFLOW_SERVING_MODEL_SERVERS_SERVER_H_ | ||
|
||
#include <memory> | ||
#include <limits> | ||
|
||
#include "grpcpp/server.h" | ||
#include "tensorflow/core/kernels/batching_util/periodic_function.h" | ||
|
@@ -59,6 +60,8 @@ class Server { | |
tensorflow::string batching_parameters_file; | ||
tensorflow::string model_name; | ||
tensorflow::int32 max_num_load_retries = 5; | ||
tensorflow::int64 total_model_memory_limit_megabytes = | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. set default to |
||
std::numeric_limits<uint64>::max() >> 20; | ||
tensorflow::int64 load_retry_interval_micros = 1LL * 60 * 1000 * 1000; | ||
tensorflow::int32 file_system_poll_wait_seconds = 1; | ||
bool flush_filesystem_caches = true; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update
total_model_memory_limit_bytes
only whenserver_options.total_model_memory_limit_megabytes
is not zero (implying someone changed the value via command line). this ensures that default limit continues to be applied as before. your current change assumes that the default is unit64_max.