prevent unloading the serving versions. #1727
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what happens if your serving process restarts (while the underlying filesystem or directory has been deleted). that still will be a disaster. no? IOW this fix is only useful until your process restarts or is preempted and gets rescheduled elsewhere in the cluster -- and when that happens you will have failures (disaster as you say). no? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In specific version policy mode, when the filesystem crashed or the version directory was deleted by mistake, the serving version may be unloaded. Which is a disaster for online service. So this pull request tries to prevent unloading the versions in configuration. If we need unload versions, changing then reloading configuration may be a good choice.