Removes duplicate style specs. #6984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angular v15, which is the one currently used in the OSS repo, uses styles with format `--mdc-` to style material components. Later versions of angular migrated to a `--mat-` prefix, and Angular v20 will update some of the names again. Our internal codebase uses the styles defined internally, so we need to use the new format. We recently set up translations internally from these "old" `--mdc-` stylings to the newer `--mat-` names, so we don't need them duplicate here, which could potentially be a source for confusion.
rileyajones
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Angular v15, which is the one currently used in the OSS repo, uses styles with format
--mdc-to style material components.Later versions of angular migrated to a
--mat-prefix, and Angular v20 will update some of the names again.Our internal codebase uses the styles defined internally, so we need to use the new format.
We recently set up translations internally from these "old"
--mdc-stylings to the newer--mat-names, so we don't need them duplicate here, which could potentially be a source for confusion.Googlers, see cl/744892387 and cl/744895577 for some details.
Technical description of changes
Remove some scss lines that are unused in the public repo.