Refactor: Use scratch buffers for reduce kernel #3281
+45
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veblush
force-pushed
the
reduce-scratch
branch
from
dd08b5f to
c6b3721
Compare
veblush
force-pushed
the
reduce-scratch
branch
from
c6b3721 to
5bdb940
Compare
veblush
force-pushed
the
reduce-scratch
branch
from
5bdb940 to
70fb620
Compare
suleshahid
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the reduce kernel to use scratch buffers allocated from the arena for temporary indices and resolved axes, instead of fixed-size stack arrays. This improves memory management and avoids potential stack overflows..
BUG=472486447