[Dep] Upgraded Flatbuffer to 25.9.23 #3296
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veblush
force-pushed
the
flatbuffer-25.9.23
branch
from
fe00223 to
00f6b50
Compare
ddavis-2015
reviewed
Jan 13, 2026
|
|
||
| TF_LITE_MICRO_TEST(IfShouldInvokeSubgraphConditionFalse) { | ||
| constexpr int kArenaSize = 5000; | ||
| constexpr int kArenaSize = 16384; |
Member
There was a problem hiding this comment.
@veblush Thats a big increase in arena size. Any ideas why this expansion happened?
ddavis-2015
reviewed
Jan 13, 2026
|
|
||
| TF_LITE_MICRO_TEST(IfShouldNotOverwriteTensorAcrossSubgraphs) { | ||
| constexpr int kArenaSize = 5000; | ||
| constexpr int kArenaSize = 16384; |
ddavis-2015
reviewed
Jan 13, 2026
| +#endif | ||
| } | ||
| case FBT_VECTOR: return static_cast<double>(AsVector().size()); | ||
| case FBT_BOOL: |
ddavis-2015
reviewed
Jan 13, 2026
|
|
||
| TF_LITE_MICRO_TEST(TestMultiSubgraphWithIf) { | ||
| constexpr int kArenaSize = 1024; | ||
| constexpr int kArenaSize = 2048; |
Member
There was a problem hiding this comment.
@veblush Did the updated flatbuffers library cause the model schema to expand in size?
ddavis-2015
reviewed
Jan 13, 2026
| flatbuffers::FlatBufferBuilder* builder = BuilderInstance(); | ||
| constexpr size_t tensor_shape_size = 1; | ||
| const int32_t tensor_shape[tensor_shape_size] = {size}; | ||
| std::vector<int32_t> shape = {size}; |
Member
There was a problem hiding this comment.
@veblush will the verboten std::vector port to non x86 platforms?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG=n/a