Skip to content

fix: deletion of invocation impacting whole invocation secondary index #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 14, 2025

Conversation

seriousben
Copy link
Member

@seriousben seriousben commented Apr 10, 2025

Context

As part of supporting the pagination of list invocations, a bug was introduced that would hide invocations of the compute graph from the list invocations if one invocation is deleted.

What

This PR addresses the issue by:

  • Deleting a single entry in the invocation secondary index as opposed to a prefix scan.
  • Adding a migration (and revamping migrations) in order to recreating the invocation secondary index which will make visible all the invocations that became hidden.
  • Improving how list invocations is being paginated in order to address UI and API issues.

Testing

Contribution Checklist

  • If a Python package was changed, please run make fmt in the package directory.
  • If the server was changed, please run make fmt in server/.
  • Make sure all PR Checks are passing.

@seriousben seriousben force-pushed the seriousben/fix-deletion-invocation-secondary-index branch from 3c7e1c2 to 6245536 Compare April 11, 2025 17:17
@seriousben seriousben marked this pull request as ready for review April 14, 2025 15:13
@seriousben seriousben force-pushed the seriousben/fix-deletion-invocation-secondary-index branch 2 times, most recently from 0aebcec to 5fab3d4 Compare April 14, 2025 16:49
@seriousben seriousben force-pushed the seriousben/fix-deletion-invocation-secondary-index branch from 5fab3d4 to 1b75e15 Compare April 14, 2025 17:07
@seriousben seriousben merged commit ee5e0f7 into main Apr 14, 2025
10 checks passed
@seriousben seriousben deleted the seriousben/fix-deletion-invocation-secondary-index branch April 14, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants